Add Content-Length header for pre-compressed files #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We only set it when we know the whole file will be sent because no Range header was on the request. Otherwise we defer to the Range mechanics of the Go standard library. Also set the Vary header when setting Content-Encoding. The rules are that Content-Length can be set with Content-Encoding but not with Transfer-Encoding. The Go Standard library does not set Content-Length when Content-Encoding is set as a precautionary measure.
duncanharris
force-pushed
the
add-content-length-header
branch
from
3395e0f
to
fe79046
Compare
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only set it when we know the whole file will be sent because no Range header was on the request. Otherwise we defer to the Range mechanics of the Go Standard library.
The rules are that Content-Length can be set with Content-Encoding but not with Transfer-Encoding.
The Go Standard library does not set Content-Length when Content-Encoding is set as a precautionary measure.
You can see as an example that Caddy does it.