Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only update gems that are in the Gemfile #12

Merged
merged 1 commit into from
Jun 5, 2016
Merged

Conversation

lpender
Copy link
Collaborator

@lpender lpender commented Jun 5, 2016

No description provided.

@lpender lpender merged commit eb7ea00 into master Jun 5, 2016
@lpender lpender deleted the lp-filter-by-gemfile branch June 5, 2016 15:36
@monfresh
Copy link
Contributor

monfresh commented Jun 5, 2016

The regex is buggy. It won't include gems that have pessimistic version constraints, but should still be updated. For example, the regex won't find a match for this output:

* devise (newest 3.5.10, installed 3.5.6, requested ~> 3.4) in group "default"

@monfresh
Copy link
Contributor

monfresh commented Jun 5, 2016

It's because the regex is only looking for single digits. It's not matching the 10 in 3.5.10. The regex should use \d+, like this:

\* (.*) \(newest (\d+\.\d+\.\d+), installed (\d+\.\d+\.\d+)

@monfresh
Copy link
Contributor

monfresh commented Jun 5, 2016

If you haven't used it before, http://rubular.com/ is a great way to test regexes.

@monfresh
Copy link
Contributor

monfresh commented Jun 5, 2016

It would be very helpful to have a more robust test suite 😄

@lpender
Copy link
Collaborator Author

lpender commented Jun 5, 2016

Agreed! I've held off for too long. Any chance you want to start it?

On Sun, Jun 5, 2016 at 12:15 PM Moncef Belyamani notifications@github.com
wrote:

It would be very helpful to have a more robust test suite 😄


You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
#12 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ABV2WognT__R8jmNWY4zs-rq-QpaM4L-ks5qIvY5gaJpZM4IuYTw
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants