fix function declarations #681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pascal Jäger <pascal.jaeger@leimstift.de>
|
This pull request fixes 29 alerts when merging 3218d31 into a798cba - view on LGTM.com fixed alerts:
Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog. |
|
also in Fedora rawhide with gcc-c++-13.2.1-5.fc40.x86_64 we need this patch , please rebase it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang16 does not allow implitic function declarations by default. Right now I am going througt gentoos packages to make them built on clang16 in the future.
This overhauls the whole source code to make this build for clang16. Please take a look at where and how I declared functions and adapt to your liking. (I could not always find out what intentions of the structure of your code imply)
See also:
https://bugs.gentoo.org/875500
https://bugs.gentoo.org/870412
Signed-off-by: Pascal Jäger pascal.jaeger@leimstift.de