Skip to content
This repository has been archived by the owner on Oct 2, 2021. It is now read-only.

Use data.resource rather than userRequest #9

Merged
merged 1 commit into from
Jan 5, 2015
Merged

Use data.resource rather than userRequest #9

merged 1 commit into from
Jan 5, 2015

Conversation

seth2810
Copy link
Contributor

@seth2810 seth2810 commented Jan 5, 2015

When I tried to use the plugin with angular-webpack-plugin, which replaces all occurrences of the variable angular to require ('exports? window.angular! angular'), when you build, I got an error:

ERROR in ./~/exports-loader?window.angular!./assets/vendor/angular/bower.json
Module parse failed: /node_modules/exports-loader/index.js?window.angular!/vendor/angular/bower.json Line 2: Unexpected token :
You may need an appropriate loader to handle this file type.
| {
| "name": "angular",
| "version": "1.3.8",
| "main": "./angular.js",

@lpiepiora
Copy link
Owner

Hey @seth2810 your patch LGTM.

I'll merge it and I will release an updated version to the NPM soon. Thanks for your contribution!

@lpiepiora lpiepiora closed this Jan 5, 2015
@lpiepiora lpiepiora reopened this Jan 5, 2015
lpiepiora added a commit that referenced this pull request Jan 5, 2015
Use data.resource rather than userRequest
@lpiepiora lpiepiora merged commit fdcd810 into lpiepiora:master Jan 5, 2015
@seth2810
Copy link
Contributor Author

seth2810 commented Jan 5, 2015

Ok, thank you!

@lpiepiora
Copy link
Owner

By the way, the updated version is already in the NPM.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants