Implement a basic decoder #2
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpil
reviewed
Jun 12, 2024
lpil
reviewed
Jul 25, 2024
| // } | ||
| // _ -> False | ||
| // } | ||
| // } |
There was a problem hiding this comment.
How come this code is commented out?
There was a problem hiding this comment.
Their encoded yaml and the encoded yaml returned from cymbal don't match so no tests are passing there atm. It will need some tweaking but it's just commented so I could work on the other tests in the meantime. I will get to it at some point but I haven't been able to because of school/work
|
I wonder if implementing the restricted subset StrictYAML would be preferrable. It is of course up to the author but the implicit behaviors that comes from the yaml 1.2 and 1.1 spec could be argued shouldn't be implemented not that we have the chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests implements a basic YAML decoder for issue #1 that should cover most standard YAML documents. A feature list can be found below. It should be sufficient to cover many common yaml files like docker-compose files and kubernetes configs.
The YAML test suite in the test directory has a preliminary implementation but is commented out as the encoded output of a cymbal yaml object does not match the expected output.
Basic Syntax
#)Data Types
|)>)true/falsenull~Collections
-)[ ]):){ })Advanced Features
&)*)<<!!)Directives
%YAML)%TAG)Document Markers
---)...)Flow Styles
{key1: value1, key2: value2})[item1, item2, item3])Special Features
!mytag)!!binary)