Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set --min-triggers to 1 #38

Merged
merged 2 commits into from
Oct 12, 2023
Merged

set --min-triggers to 1 #38

merged 2 commits into from
Oct 12, 2023

Conversation

weizmannk
Copy link
Contributor

The purpose of this pull request is to enable simulation when only one detector (H1 or L1 or V1 or K1) is in operation during a run. There is no coincidence . This ovoid the error. For more https://github.com/lpsinger/ligo.skymap/blob/main/ligo/skymap/tool/bayestar_inject.py#L318

The purpose of this pull request is to enable simulation when only one detector (H1 or L1 or V1 or K1) is in operation during a run. There is no coincidence . This ovoid the error. For more https://github.com/lpsinger/ligo.skymap/blob/main/ligo/skymap/tool/bayestar_inject.py#L318
Copy link
Owner

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also need to add the --min-trigger argument to bayestar-inject.

Please fix the spelling and grammatical errors in the commit message.

@weizmannk
Copy link
Contributor Author

@lpsinger you mean to replace --min-triggers by --min-trigger in bayestar-inject , then set default value to 1 ?
https://github.com/lpsinger/ligo.skymap/blob/main/ligo/skymap/tool/bayestar_inject.py#L262

@lpsinger
Copy link
Owner

Yes, I meant --min-triggers.

weizmannk

This comment was marked as resolved.

@weizmannk weizmannk changed the title fix min-triggers to 1 set --min-triggers to 1 Oct 12, 2023
Copy link
Owner

@lpsinger lpsinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the runs/%/events.xml.gz target already has the --min-triggers 1 option passed to bayestar-realize-coincs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants