Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for TablePlus #1164

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

rizkysyazuli
Copy link

@rizkysyazuli rizkysyazuli commented May 14, 2018

Added support for TablePlus, the database manager. This will backup the user's saved connection, minus the password, which is saved in Keychain.

Oh, and it seems my previous pull request #967 is also included here.

update Cyberduck bookmark location for the sandboxed & later versions
Added configuration for [iTermocil](https://github.com/TomAnthony/itermocil), an iTerm window & pane launcher.

From their readme:
iTermocil allows you to setup pre-configured layouts of windows and panes in iTerm2, having each open in a specified directory and execute specified commands.
Library/Application Support/Cyberduck
Library/Containers/ch.sudo.cyberduck/Data/Library/Application Support/Cyberduck
Library/Group Containers/G69SCX94XU.duck/Library/Application Support/duck
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is gonna work, it's specific to each computer no?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. These paths are documented in the Cyberduck wiki page.

https://trac.cyberduck.io/wiki/help/en/faq#Preferencesandapplicationsupportfileslocation

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird. Did you test the config yourself? e.g. mackup backup followed by mackup uninstall and mackup restore?

I suggest splitting those 2 apps in 2 PR so we can merge the easy one and dig into the other one.

Copy link
Author

@rizkysyazuli rizkysyazuli Aug 28, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The mackup backup command works fine. i have it in my personal .mackup config folder. But i haven't tried running the uninstall and restore command.

But i just noticed the path in line 7 doesn't exists. If i'm not mistaken, that was for an older version of Cyberduck.

Library/Containers/ch.sudo.cyberduck/Data/Library/Application Support/Cyberduck

But sure. i will try to split those PR a bit later. sorry for the trouble.

Copy link
Contributor

@ttuygun ttuygun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TablePlus paths seems correct. Keep in mind that you can always find the related config files or backup files using AppCleaner or AppDelete
screen shot 2018-10-27 at 12 04 32

@vyuldashev
Copy link

Any progress on this PR? Really missing TablePlus support.

name = TablePlus

[configuration_files]
Library/Application Support/com.tinyapp.TablePlus
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need Library/Application Support/com.tinyapp.TablePlus/Data in order to save the connections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants