Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initial commit for creating a demo #6

Merged
merged 12 commits into from
Sep 24, 2019
Merged

initial commit for creating a demo #6

merged 12 commits into from
Sep 24, 2019

Conversation

wir963
Copy link
Collaborator

@wir963 wir963 commented Aug 13, 2019

@TracyYXChen this PR is to create your requested demo. Please play around with the code and see what you think and provide any suggestions.

@TracyYXChen
Copy link

TracyYXChen commented Aug 14, 2019

@wir963 Thanks! It works perfectly. I have successfully applied it to my simulation dataset.
Yet there is one big issue and one minor issue:

  • The estimation of exposures on the held-out dataset, i.e. could you please include stm-heldout*.R in the demo, too?
  • Please add package r-argparse to the environment file

@wir963
Copy link
Collaborator Author

wir963 commented Sep 12, 2019

@TracyYXChen could you take a look at my changes and see if they make sense to you. If they do, please approve and I'll merge it in.

@wir963 wir963 merged commit af9c55c into master Sep 24, 2019
@wir963 wir963 deleted the demo branch September 24, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants