Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Categorise and output the landing eg. "good, bad, excellent" #7

Closed
jmhelms opened this issue Sep 11, 2017 · 27 comments
Closed

Categorise and output the landing eg. "good, bad, excellent" #7

jmhelms opened this issue Sep 11, 2017 · 27 comments

Comments

@jmhelms
Copy link

jmhelms commented Sep 11, 2017

I also use X-Plane and it has a program like
yours...that program "rates" your landing
such a good, acceptable, hard, "Anyone
Survive?, " etc.

I see your statistics, but not sure I can make
much common sense of them...

Appreciate your consideration of this request..

John Helms, Houston, TX
@allebb
Copy link
Contributor

allebb commented Sep 11, 2017 •
edited
Loading

Hi John,

I sure can add something like that... Did you have any recommendations on the FPM "limits" to define/calculate the lanidng? Something along these lines maybe? - Feel free to let me know if I'm way off the mark on any of these/recommend other rating text messages...

Lower limit (FPM) Upper limit (FPM) Rating text
0 90 Great
90 200 Good
200 400 Acceptable
400 500 Bad
500 700 Dangerous
700 > 700 Fatal

@allebb allebb closed this as completed Sep 11, 2017
@allebb
Copy link
Contributor

allebb commented Sep 11, 2017 •
edited
Loading

Whoops, my bad, didn't mean to close this...

@allebb allebb reopened this Sep 11, 2017
@jmhelms
Copy link
Author

jmhelms commented Sep 11, 2017 via email

@allebb
Copy link
Contributor

allebb commented Sep 19, 2017

Hi John,

Sorry for the late reply, I've been giving this some thought (as, like you I'm not sure if this would be valid for ALL aircraft but I know that my example is pretty close for commercial aircraft eg. Airbus A320 etc.)...

Anyway, my plan is to offer a 'default' set of limits (as per my above examples) but will also allow people to upload their own aircraft specific ones too (simply drop in a folder) and if the aircraft name matches the config file name then it'll use those parameters for outputting the landing "result".

Will be starting work on this, this week 👍 and also the new version of the LRM statistics/flight report site :)

With regards to the donation - If you wanted to donate (don't feel obliged to though) you could always send me a donation to my PayPal account: bobbyallen.uk@gmail.com which would be much appreciated :)

Cheers,
Bobby

@allebb
Copy link
Contributor

allebb commented Sep 19, 2017

...I'll also add a section to the main LRM client site where users could "share" their configurations for certain aircraft types - may make things easier and get the community "sharing" their own configuration/research on landing rate limits for certain aircraft.

@jmhelms
Copy link
Author

jmhelms commented Sep 19, 2017 via email

@jmhelms
Copy link
Author

jmhelms commented Sep 19, 2017 via email

@allebb
Copy link
Contributor

allebb commented Sep 19, 2017

Hey John,

First of all, many thanks for the kind donation 👍

With regards to the new version notification - Yes, the LRM client (unless you've disabled it in the menus' will automatically check and notify you if there is a new version available.

Will do my best to get the new version of the client completed and released before the end of next week :)

Speak soon and would really appreciate if you could give me feedback on the new feature once it's been released - I'll also update this issue too once it's released so that you can download and install the latest version (just incase you've disabled the 'Check for updates' option :))

@jmhelms
Copy link
Author

jmhelms commented Sep 19, 2017 via email

@allebb
Copy link
Contributor

allebb commented Oct 7, 2017 •
edited
Loading

Hi John,

Just to let you know that I've now started work on this, and so far my testing is going great :) - Hopefully be released midweek!

The LRM site is now back online too (in case you hadn't noticed) - You can re-login and look over your old flight logs and start logging those flights again etc!

Over the coming weeks, I'm adding massive amounts of improvements to that site too and giving it a facelift (making it look far better and new functionality).

Speak soon,
Bobby

@jmhelms
Copy link
Author

jmhelms commented Oct 8, 2017 via email

@jmhelms
Copy link
Author

jmhelms commented Oct 8, 2017 via email

@allebb
Copy link
Contributor

allebb commented Oct 8, 2017 •
edited
Loading

Yes, it will track your flight as long as you have created and entered an API token into the client preferences window, see this page for instructions on how to do it :)

https://lrmlive.com/docs/client#lrmlive-account-integration

Hope this helps :)

Kind regards,
Bobby

@jmhelms
Copy link
Author

jmhelms commented Oct 9, 2017 via email

@allebb
Copy link
Contributor

allebb commented Oct 9, 2017

Hi John,

The GPS refresh rate is tied to how often the client sends your aircraft GPS coordinates back to the server... I'll see what other improvements I can do in the next release :)

@jmhelms
Copy link
Author

jmhelms commented Oct 9, 2017 via email

@allebb
Copy link
Contributor

allebb commented Nov 22, 2017

Hi John, This code has now been added and fully tested in the latest version of the client, the client will be released tomorrow evening (GMT) (just adding a few other features too :))

Keep an eye on the client as it'll soon prompt you to update to make use of the new functionality 👍

@allebb allebb closed this as completed Nov 22, 2017
@jmhelms
Copy link
Author

jmhelms commented Nov 23, 2017 via email

@allebb
Copy link
Contributor

allebb commented Nov 23, 2017 •
edited
Loading

No problem :) - I hope you like the new look of the new LRMLive stats site that I released this week! 👍

Happy Thanksgiving to you too!

Oh and btw... The new client is fully compatible with X-Plane too (in-case you was interested in using it for that too :))

@allebb
Copy link
Contributor

allebb commented Nov 23, 2017 •
edited
Loading

Evening John!!

As promised the new LRM client has just been released, you can grab it from the LRM Client site (https://client.lrmlive.com) - I've not yet updated the "check client updates" API yet so clients won't yet prompt to download the latest version - I just want to make sure we're all totally "bug free" first.

I decided that instead of using words like "good", "great" etc. (as there seems to be a lot of ambiguity on the internet as to what is refereed to as a "good" or "great" landing but instead I categorised them with the rates as follows (I changed the ranges too based on what I had read pilots generally feel about landing rate categories):-

Lower limit (FPM) Upper limit (FPM) Rating text Description
0 85 Smooth A greased and smooth landing that in wet conditions and short runways could not be the best
86 209 Perfect The best mix of smooth landing and contact/prevention of aqua-planning etc.
210 349 Firm Great in certain circumstances (short runways, wet conditions)!
350 399 Hard Not damaging to the aircraft but getting that way - Passengers are probably a bit shaken though!
400 549 Concerning Should probably get the landing gear checked out by engineers as it's probably breached the design landing rate limits
550 799 Dangerous For various aircraft types this could be dangerous and the aircraft could start to break up
> 800 Fatal It can't be good... I assume, if you survive a landing at this rate you're pretty lucky!

I've also added another really cool feature (which if you fly airliners you may like) - If you do a landing of less than -300fpm - You can enable the "Cabin Applause" setting in the preferences and you will hear a faint applause of the passengers :) - It's a pretty neat feature if I say so myself :)

Hope you manage to give it a test and hopefully let me know what you think 👍

@jmhelms
Copy link
Author

jmhelms commented Nov 24, 2017 via email

@allebb
Copy link
Contributor

allebb commented Nov 24, 2017

Hi John,

Thanks so much for doing some testing for me, it was actually a massive help!!! I failed to find those two bugs (clapping playing regardless of if the user has enabled it and the refresh rate of landing states updating the form).

I can however advised that I've now fixed BOTH issues and have tested and all seems to be working perfect now!

I would really appreciate it if you could re-download the file again (I've updated it on the site now) and just re-run the installer and do a few final tests/re-test those issues before I publicly announce the new release.

Thanks for sharing that URL too... I'll check it out over the weekend :)

Hope to hear from you soon,

All the best,
Bobby

@jmhelms
Copy link
Author

jmhelms commented Nov 24, 2017 via email

@allebb
Copy link
Contributor

allebb commented Nov 24, 2017

Thanks for re-testing and your further feedback John :)

I have some answers for you....

With regards to the install path, that in theory is correct as you've you've upgraded over the top of your old version (and therefore the installer detected the current path) - If you had uninstalled and re-installed, it will prompt you for the path (as it didn't detect an older version on your PC) - Hope that makes sense?

With regards to capturing all landings - if these was very quickly take-offs and landings (takeoff and landing within 30 seconds, then no, it won't register due to to the logic I've added for preventing bounce registration, and prevents exploitation of the FSHub.io platform - I guess, this limit is not too much of an issue for most users.

I will do more testing on the Refresh rate issues tomorrow, all of my testing following my changes had been instant though :(

Could I just ask though, in regards to the Refresh rate - If you run the simulator in Windowed mode and have the client open next to it, when you land does the form show the landing rate instantly but just doesn't appear in the simulator until several seconds later? - I assume this may be the case for you and I can therefore only assume that you must have rather low FPS? - Although I send the landing notification to the simulator instantaneously, it's the simulator that may lag in displaying the message (this is linked to FPS) - If you have the time to just try the above and let me know that would be really great, just to confirm that it is an FPS issue rather than a client issue?

So I assume you mean replace "Fatal" with "R.I.P"? :) - "Dangerous" is one before my "Fatal" rating - I think I'll keep it as "Fatal" (means the same thing I guess) but will add, in the next release an option to customise these names. "R.I.P" I personally feel is a little less professional than "Fatal" lol. - I do appreciate your feedback though and I will add in the ability to change the names in future.

Once again, your help is much appreciated :) - It would also be really interesting to know, if you tried running it in X-Plane too and whether of not you had an issue with the landing rate not appearing for several seconds?

@jmhelms
Copy link
Author

jmhelms commented Nov 25, 2017 via email

@allebb allebb changed the title New Feature Request Categorise and output the landing eg. "good, bad, excellent" Nov 25, 2017
@allebb
Copy link
Contributor

allebb commented Nov 25, 2017

Hi John, thank you so much for getting back to me again, I really thought that you may have had enough of the testing haha :)

That's really great to hear and I'm really pleased that all seems to work well in both sims 👍

I will certainly keep you updated on progress when new features etc are released!

I'm located about 90 miles from London (in the UK) - So greetings to you and your family from England 👍

@jmhelms
Copy link
Author

jmhelms commented Nov 25, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@allebb @jmhelms