-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frank fix + coherence tests on Archimedeans + marginals tests on all copulas #65
Conversation
7373fcb
to
8f13fc9
Compare
@Santymax98 Look at the new tests, everything is working correclty even for |
@lrnv Does that have to do with the amount of memory required? |
@Santymax98 Could you provide a simple piece of code that shows this error ? I could add it as a test here as i think this PR should solve it, but I am not sure. Edit: I just added the test and it passes here. Do you have other interesting cases that we could test ? I guess that something more systematic could be done to check pdfs of all copulas at once, the random adding of tests that i am doing here is a bit messy |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
+ Coverage 73.81% 75.87% +2.05%
==========================================
Files 28 28
Lines 550 572 +22
==========================================
+ Hits 406 434 +28
+ Misses 144 138 -6 ☔ View full report in Codecov by Sentry. |
I am very bad at writing code in this environment, I think it would be more useful for me to send it by email |
Yes no problem send it by mail or just copy/paste it here :) Know tha tyou can use triple-ticks blocs to format code here: this is some julia(code) try to edit this mesage to see the ticks |
8185e22
to
fb27601
Compare
I think I will merge this like that and then come back on another PR to fix the issue of the tests not passing on 1.6. |
trying to fix #64, not working yet.
closes #68 too
Relevant sources:
https://github.com/cran/copula/blob/master/src/rLog.c
https://github.com/cran/copula/blob/master/R/frankCopula.R
https://juliastats.org/LogExpFunctions.jl/stable/