Updated React version and added option to get the current month's data #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrojas94
requested changes
Feb 15, 2019
| }; | ||
| } | ||
|
|
||
| componentDidUpdate( prevProps, prevState) { |
There was a problem hiding this comment.
Remove this entire method, it's doing nothing really.
| @@ -51,6 +64,36 @@ export default class Calendar extends React.Component { | |||
| ); | |||
| } | |||
|
|
|||
| // _verifyWeeksChange( weeks ) { | |||
There was a problem hiding this comment.
Any reason for this to be commented out? If not needed, remove please.
| @@ -60,10 +103,17 @@ export default class Calendar extends React.Component { | |||
| const { | |||
| timeslots, | |||
| initialDate, | |||
| onMonthChange | |||
There was a problem hiding this comment.
This prop is not being used here, I only see it in this._onMonthChange, so it's an unused var.
| // this.setState({ | ||
| // weeksStart: weeks[0], | ||
| // weeksEnd: weeks[weeks.length - 1] | ||
| // }); |
| @@ -45,6 +45,7 @@ export default class App extends React.Component { | |||
| console.log('Last selected timeslot:'); | |||
| console.log(lastSelected); | |||
| } } | |||
| onMonthChange = { (month) => {console.log(month)}} | |||
There was a problem hiding this comment.
I see no point on doing this (?). If what you're looking to see is whether this works or not, write unit tests instead.
| this.startDate = startDate; | ||
| this.endDate = endDate; | ||
|
|
||
| this.props.onMonthChange({ startDate, endDate }); |
There was a problem hiding this comment.
Use destructuring here:
const { onMonthChange } = this.props
| // } | ||
|
|
||
| _onMonthChange(weeks) { | ||
| const startingWeek = weeks[0]; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.