Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this a problem of mine or...? #2

Closed
CupricAdamo opened this issue Feb 6, 2021 · 18 comments
Closed

Is this a problem of mine or...? #2

CupricAdamo opened this issue Feb 6, 2021 · 18 comments
Assignees
Labels
bug Something isn't working

Comments

@CupricAdamo
Copy link

Does the app support .mkv videos?
'cuz I've downloaded an anime and tried to open it with the app but doesn't load it.

@arianneorpilla
Copy link
Owner

arianneorpilla commented Feb 7, 2021

Ah, whoops. Mispressed with the issue close.

Please provide more details, like your device make and model, Android version, what video you're playing and whatever else you're loading onto the app.

Occasionally some videos won't play and that prompts me to exit back to the menu and try again, but I've never encountered a local video that refuses to play after attempting again. If you can help provide details that will assist me in reproducing this issue, it would really let me sort this out.

All of the videos I've been testing with have actually been Matroska videos so they should be playing.

@arianneorpilla arianneorpilla self-assigned this Feb 7, 2021
@arianneorpilla arianneorpilla added the bug Something isn't working label Feb 7, 2021
@CupricAdamo
Copy link
Author

My smartphone is a xiaomi redmi 9c. Android 10qp1a, MIUI 12.0.6.
I tried many times to view two different videos of 1gb or more. I can say this videos aren't broken because I can view them with MI video player and VLC.

@arianneorpilla
Copy link
Owner

arianneorpilla commented Feb 7, 2021

EDIT FOR ARCHIVAL PURPOSES: This is ill-advised information and I wrote this not knowing and properly implementing the workaround. What worked was changing the target SDK to 29, using legacy storage and using an older file_picker version. This made the app work on Android 11 with no caching, tested on an emulator and users report no issues so far ever since.

How much storage space do you have left remaining on your phone? Due to the scoped storage changes in Android 11, videos have to be cached into temporary storage (as in, they have to be copied by the app into storage to play, thus you will need twice the size of the videos you are playing). Currently, I clear this cache every time the app starts. If your amount of free space is just below the size of the video file you have chosen, the video would be unable to play.

I implemented a change in how files are selected in order to allow Android 11 users to use the app, at the cost of loading time and storage space issues. This is a change that was not necessary in prior versions of the app before 0.3.2, and it is a requirement for the app to work on versions above Android 10.

If this is indeed the issue you are facing, I would just like to express that I am also very unhappy with this change as I am an Android 10 user who now experiences slower video playback on my own app and would like to bring back the faster, instant video playback without any storage requirements or workarounds required to let users run the app on Android 11. I will probably implement two versions for users to download so that they can choose between the two options.

In the meantime, I recommend that you use a version below 0.3.2 if you wish to use the app without these storage issues. Please do confirm if this guess is correct, though. It may be a legitimate player issue.

@arianneorpilla
Copy link
Owner

That does make it a player issue. Could you let me know some details on the file you are playing?

@CupricAdamo
Copy link
Author

It's a .mkv file, 1.59gb, works on vlc and mi video. Now tried to view a 6mb .kjv file, it didn't work. But it worked with .mp4 files.

@CupricAdamo
Copy link
Author

I'll download an older version how you suggested

@arianneorpilla
Copy link
Owner

The app's video player uses ExoPlayer, which has a list of supported formats which can be found here. I have used MKV videos in my testing and found no major issues that prevented me from playing my videos. If you can provide more details in regards to the video you are playing, I may be able to reproduce the issue.

If you can, please send me a log or a screenshot with information about the video file which you can get via this application or something similar. It is concerning to me that some video files may not work with the application, so please let me know if you can provide more details.

@CupricAdamo
Copy link
Author

How do I send them?

@arianneorpilla
Copy link
Owner

You may copy paste the entire log here or attach the photos in your comment while you're editing them.

@CupricAdamo
Copy link
Author

Screenshot_2021-02-07-12-11-52-953_com google android apps docs

@CupricAdamo
Copy link
Author

CupricAdamo commented Feb 7, 2021

Screenshot_2021-02-07-12-12-14-267_com google android apps docs

@CupricAdamo
Copy link
Author

That was the biggest file i have

@CupricAdamo
Copy link
Author

This is the smallest
Screenshot_2021-02-07-12-19-04-909_com google android apps docs

@CupricAdamo
Copy link
Author

Both of them don't work on jidoujisho for me

@arianneorpilla
Copy link
Owner

Thank you, this is very useful. I'll look into what alternatives I can use for the video player to solve this issue.

@arianneorpilla
Copy link
Owner

arianneorpilla commented Feb 8, 2021

I should be able to support these formats in the upcoming release. I will keep this issue open until that version is released.

@arianneorpilla arianneorpilla added the wontfix This will not be worked on label Mar 4, 2021
@arianneorpilla
Copy link
Owner

Unfortunately, I don't suppose I can migrate the application to VLC in a stable manner so I don't think I can fix this at the moment until significant updates. In the meantime, the app should support anything that ExoPlayer supports on Android -- alternate videos would have to be found otherwise unfortunately.

I think implementing YouTube as is in addition to keeping subtitles working the way they are would have to change otherwise. I'll close this issue but feel free to bring it up should more significant issues arise.

@arianneorpilla
Copy link
Owner

I am briefly reopening this issue to announce that I have recently migrated the app to use VLCKit in the 0.6.0 release and that the videos you are having issues with should now be compatible.

If there are any further issues, please let me know. And with that, I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants