Previews: Add touch gesture support #837
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tested this on Safari on an iPhone 8 plus (iOS 15) and by using the mobile device emulation modes on Firefox and Chrome. For videos, if not in full screen and not playing, swiping works fine, so you can use this to switch between videos too. Once playing the native video player is in control and touch events don't reach JavaScript. To me, this feels very natural. I haven't really tested this yet with text or audio content. |
On devices with touch support, maps left and right swipes to moving to the next and previous item, and double-taps to toggling fullscreen on and off.
mjpieters
force-pushed
the
preview-touch-support
branch
from
e45e209
to
1b1b6f1
Compare
m7snxx
approved these changes
Jul 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On devices with touch support, maps left and right swipes to moving to
the next and previous item, and double-taps to toggling fullscreen on
and off.
Fixes #713