Fix for #87 #174
Merged
Fix for #87 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
I wanted to address the Firefox problem #87 and made a fix for it.
Description
We can use
PointerEvent.targetto get the element the user dragged the connection to.If we drag the connection over the connectors on the side of an UML element, we can get the connectors direction attribute.
This fixes the problem in Firefox as well.
I inserted an if statement to check if the element we dragged the connection to has a direction attribute, if it does, use that, if it doesn't, use the old way.
Steps for Testing