Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development: Update dependencies #272

Merged
merged 4 commits into from
Nov 29, 2022
Merged

Development: Update dependencies #272

merged 4 commits into from
Nov 29, 2022

Conversation

minrows
Copy link
Contributor

@minrows minrows commented Nov 16, 2022

Motivation and Context

This PR simply updates the dependencies of Apollon.

Steps for Testing

  1. Clone the repo
  2. Execute commands: yarn install, yarn build followed by yarn test
  3. Observe no tests are failing and the application is running succesfully with yarn start command

@minrows minrows mentioned this pull request Nov 16, 2022
Closed
@minrows minrows self-assigned this Nov 16, 2022
@minrows minrows added the dependencies Pull requests that update a dependency file label Nov 16, 2022
mertyldrr
mertyldrr reviewed Nov 24, 2022
View reviewed changes
Copy link
Contributor

@mertyldrr mertyldrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple o test suites failed for me, are these important or should I just check "Tests" for future cases? Application worked as expected on my local.

apollon-tests

@minrows
Copy link
Contributor Author

minrows commented Nov 26, 2022

A couple o test suites failed for me, are these important or should I just check "Tests" for future cases? Application worked as expected on my local.

apollon-tests

Issue resolved in commit

mertyldrr
mertyldrr approved these changes Nov 26, 2022
View reviewed changes
Copy link
Contributor

@mertyldrr mertyldrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests are failing and works as expected 👍

akesfeden
akesfeden approved these changes Nov 28, 2022
View reviewed changes
Copy link

@akesfeden akesfeden left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, yarn test runs successfully, adding/removing/linking elements, read-only mode and interactive mode seem to be working as expected.

@minrows minrows added the ready for merge pr is ready to bemerged label Nov 29, 2022
@krusche krusche merged commit 77e3e6e into develop Nov 29, 2022
@krusche krusche deleted the chores/update-minor-dependencies branch November 29, 2022 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akesfeden akesfeden akesfeden approved these changes

@mertyldrr mertyldrr mertyldrr approved these changes

@krusche krusche Awaiting requested review from krusche

@bassner bassner Awaiting requested review from bassner

Assignees

@minrows minrows

Labels
dependencies Pull requests that update a dependency file ready for merge pr is ready to bemerged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@minrows @akesfeden @mertyldrr @krusche