`Development`: Update typescript #9051

krusche · 2024-07-14T20:28:54Z

Checklist

General

I tested all changes and their related features with all corresponding user types on a test server.
Language: I followed the guidelines for inclusive, diversity-sensitive, and appreciative language.
I chose a title conforming to the naming conventions for pull requests.

Client

Important: I implemented the changes with a very good performance, prevented too many (unnecessary) REST calls and made sure the UI is responsive, even with large data.
I strictly followed the client coding and design guidelines.
Following the theming guidelines, I specified colors only in the theming variable files and checked that the changes look consistent in both the light and the dark theme.
I documented the TypeScript code using JSDoc style.

Motivation and Context

Use the latest version of typescript

Description

This PR includes an upgrade prompted by the updated version of TypeScript, which no longer supports "suppressImplicitAnyIndexErrors": true. As a result, all implicit any assertions have been revised or rewritten.

Steps for Testing

Since this PR only modifies the typing of some variables, the behavior of the code should remain unchanged. However, it is crucial to verify that the affected areas function as expected, with a particular focus on testing modeling exercises and their assessment.

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.

Review Progress

Code Review

Code Review 1
Code Review 2

Manual Tests

Test 1
Test 2

Test Coverage

unchanged

Summary by CodeRabbit

New Features
- Updated Angular and related packages to improve performance and introduce new features.
- Enhanced type safety across various components and services.
Bug Fixes
- Improved error handling and data structure management in multiple components.
Refactor
- Streamlined initialization logic and improved property access methods in several components.
- Transitioned from plain objects to Map objects for better data management.
- Centralized search initialization logic in the CompetencySearchComponent tests for improved maintainability.
Chores
- Removed outdated configurations and properties to enforce stricter type checks.

Co-authored-by: Lucas Welscher <ga53foy@mytum.de>

Jan-Thurner

Tested these features on TS1:
Modeling Exercise Creation ✅
Modeling Exercise Participation ✅
Competency import ✅
Tutorial group session creation ✅
tutorial Group session student view ✅
short answer questions ✅
Lecture Unit management ✅

coolchock

Tested in testing session on ts1. Tested components for which the types where changed, no issues found.

florian-glombik

Tested the changes on ts1 in testing session

Tested modeling exercise (creation, participation, assessment, review of assessment)
Tested sidebar and course switching
Tested programming exercise grading configuration
Participated in programming exercise
Tested text exercise (creation, participation, assessment

Found an unrelated issue in the assessment Assessment: Tutor note input field available if not submission is selected #9203

edkaya

Code changes lgtm

...cises/programming/manage/grading/tasks/programming-exercise-grading-tasks-table.component.ts

pzdr7 · 2024-08-09T14:04:16Z

src/main/webapp/app/exercises/programming/manage/grading/tasks/programming-exercise-task.ts

@@ -12,4 +12,6 @@ export class ProgrammingExerciseTask extends ProgrammingExerciseServerSideTask {
    resultingPoints?: number;
    resultingPointsPercent?: number;
    stats: TestCaseStats | undefined;
+
+    [key: string]: number | string | undefined | TestCaseStats | ProgrammingExerciseTestCase[];


This also sticks out a bit. Why do we need to define for arbitrary strings that a programming exercise task might have attributes of type number | string | undefined | TestCaseStats | ProgrammingExerciseTestCase[]?

I do not understand why we need this here, can you explain it to us @SimonEntholzer ?

When removing this type declaration I do not seem to encounter errors in the files that use the ProgrammingExerciseTask

I checked the following files:

programming-exercise-grading-tasks-table.component.ts

programming-exercise-task.component.ts

programming-exercise-task.service.ts

programming-exercise-grading-tasks-table.component.spec.ts

I remove the type and the client and e2e tests are still running through, also double checked the programming grading table and it worked, I am quite confident that the type was not necessary

Might have been an IDE related issue on my side. It looked like without this additional attribute accessing some of the ProgrammingExerciseTask with the ....["..."] notation wouldn't work. Seems like it does work without the additional key attribute 👍

edkaya

Reapprove after changing types

florian-glombik

Re-approve after re-testing grading configuration for programming exercises after last two commits

Stephan Krusche and others added 8 commits July 14, 2024 16:04

update eslint to 9

bd32a25

simplify package.json

6271f60

small improvement in index.html

2fc083a

Apply suggestions from code review

8f01dec

Co-authored-by: Lucas Welscher <ga53foy@mytum.de>

add global rule for no unused vars caught errors

1140262

update critters

b018b37

update package-lock.json

a308457

update typescript and fix the first errors

233108b

github-actions bot assigned krusche Jul 14, 2024

github-actions bot added tests client Pull requests that update TypeScript code. (Added Automatically!) cypress Pull requests that update cypress tests. (Added Automatically!) labels Jul 14, 2024

florian-glombik and others added 18 commits July 15, 2024 11:23

Fixing CollapseState type

acc89e3

Fixing sidebar directive types

14c33be

Fixing exercise detail directive types

4a59ad2

Fixing password reset types

bfbb2ef

Fix types in course management card component

c373c26

Fixing types in sidebar component

14ff012

Fixing types course management component

dedf094

Fixing types in test-case-distribution

fc3ae09

fix types in navbar component

dd9c211

fix types in course-group.component.ts

5373f31

fix types in course-scores.component.ts

7a7c5f9

Experimental: Remove Webpack HMR

41393a5

fix types in lecture-unit-management.component.ts

6bd9e22

Fix some more problems

ab0ad82

fix types in programming-exercise-participation.service.ts

3a4a160

fix types in export-row-builder.ts

ffd819e

fix types in abstract-dialog.component.ts

19507a8

fix types in metrics-modal-threads.component.ts

5549c58

Jan-Thurner previously approved these changes Aug 9, 2024

View reviewed changes

florian-glombik removed the lock:artemis-test1 label Aug 9, 2024

coolchock previously approved these changes Aug 9, 2024

View reviewed changes

florian-glombik previously approved these changes Aug 9, 2024

View reviewed changes

edkaya previously approved these changes Aug 9, 2024

View reviewed changes

pzdr7 reviewed Aug 9, 2024

View reviewed changes

Fixing type for sort in the grading table

059c60a

florian-glombik dismissed stale reviews from edkaya, coolchock, Jan-Thurner, coderabbitai[bot], and themself via 059c60a August 9, 2024 14:38

coderabbitai bot previously approved these changes Aug 9, 2024

View reviewed changes

Remove not needed types

776b8b8

florian-glombik dismissed coderabbitai[bot]’s stale review via 776b8b8 August 9, 2024 15:06

coderabbitai bot approved these changes Aug 9, 2024

View reviewed changes

florian-glombik added the deploy:artemis-test1 label Aug 9, 2024

florian-glombik temporarily deployed to artemis-test1.artemis.cit.tum.de August 9, 2024 17:24 — with GitHub Actions Inactive

github-actions bot added lock:artemis-test1 and removed deploy:artemis-test1 labels Aug 9, 2024

florian-glombik requested review from Jan-Thurner, coolchock and edkaya August 9, 2024 17:33

florian-glombik removed the lock:artemis-test1 label Aug 9, 2024

pzdr7 approved these changes Aug 9, 2024

View reviewed changes

edkaya approved these changes Aug 9, 2024

View reviewed changes

florian-glombik approved these changes Aug 9, 2024

View reviewed changes

krusche merged commit edbd614 into develop Aug 10, 2024
33 of 36 checks passed

krusche deleted the chore/update-typescript branch August 10, 2024 06:00

JohannesWt pushed a commit that referenced this pull request Sep 23, 2024

Development: Update typescript (#9051)

ecb3f32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`Development`: Update typescript #9051

`Development`: Update typescript #9051

krusche commented Jul 14, 2024 •

edited by florian-glombik

Loading

Jan-Thurner left a comment

coolchock left a comment

florian-glombik left a comment

edkaya left a comment

pzdr7 Aug 9, 2024

florian-glombik Aug 9, 2024 •

edited

Loading

florian-glombik Aug 9, 2024

SimonEntholzer Aug 12, 2024

edkaya left a comment

florian-glombik left a comment

Development: Update typescript #9051

Development: Update typescript #9051

Conversation

krusche commented Jul 14, 2024 • edited by florian-glombik Loading

Checklist

General

Client

Motivation and Context

Description

Steps for Testing

Testserver States

Review Progress

Code Review

Manual Tests

Test Coverage

Summary by CodeRabbit

Jan-Thurner left a comment

Choose a reason for hiding this comment

coolchock left a comment

Choose a reason for hiding this comment

florian-glombik left a comment

Choose a reason for hiding this comment

edkaya left a comment

Choose a reason for hiding this comment

pzdr7 Aug 9, 2024

Choose a reason for hiding this comment

florian-glombik Aug 9, 2024 • edited Loading

Choose a reason for hiding this comment

florian-glombik Aug 9, 2024

Choose a reason for hiding this comment

SimonEntholzer Aug 12, 2024

Choose a reason for hiding this comment

edkaya left a comment

Choose a reason for hiding this comment

florian-glombik left a comment

Choose a reason for hiding this comment

`Development`: Update typescript #9051

`Development`: Update typescript #9051

krusche commented Jul 14, 2024 •

edited by florian-glombik

Loading

florian-glombik Aug 9, 2024 •

edited

Loading