-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General
: Add course summary to course deletion dialog
#9186
General
: Add course summary to course deletion dialog
#9186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small comments
...in/webapp/app/course/manage/course-management-tab-bar/course-management-tab-bar.component.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Besides the comments of Patrik code looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed the code and have some change requests
- Please use more specific types
- Please use more descriptive variable names
- Please adjust the german translations
- I think it would be better to only fetch the information when we are actually using the delete functionality, which should be an edge case
...in/webapp/app/course/manage/course-management-tab-bar/course-management-tab-bar.component.ts
Outdated
Show resolved
Hide resolved
...in/webapp/app/course/manage/course-management-tab-bar/course-management-tab-bar.component.ts
Outdated
Show resolved
Hide resolved
...in/webapp/app/course/manage/course-management-tab-bar/course-management-tab-bar.component.ts
Outdated
Show resolved
Hide resolved
…' into feature/summary-course-deletion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approve code and tested locally, thanks for addressing the requested changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add tests for the new functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested on ts3, works as expected 👍
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
Usability
: Add course summary to course deletion dialogGeneral
: Add course summary to course deletion dialog
e9695e4
into
feature/summary-on-exam-deletion
Checklist
General
Server
Client
Motivation and Context
Implements #9178.
Description
Steps for Testing
Prerequisites:
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots