Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM: Add Langchain LLM wrapper classes #57

Merged
merged 13 commits into from
Feb 14, 2024
Merged

Conversation

Hialus
Copy link
Member

@Hialus Hialus commented Feb 14, 2024

Motivation

Langchain uses its own wrapper classes for LLM handling. Since we also use our own subsystem for handling LLMs we need to provide a wrapper for the wrapper.

Description

I added wrappers for all 3 currently supported LLM types (completion, chat, embedding) using the Langchain base classes as reference.

@Hialus Hialus self-assigned this Feb 14, 2024
@Hialus Hialus added this to the 1.0.0-Prototype milestone Feb 14, 2024
# Conflicts:
#	app/llm/basic_request_handler.py
#	app/llm/request_handler_interface.py
#	requirements.txt
Copy link
Contributor

@kaancayli kaancayli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seen in action. Lgtm

Copy link
Contributor

@MichaelOwenDyer MichaelOwenDyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

Copy link
Member

@bassner bassner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just have one minor suggestion

Copy link
Member

@bassner bassner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm

@Hialus Hialus merged commit 626a92c into main Feb 14, 2024
4 checks passed
@Hialus Hialus deleted the feature/llm/langchain-wrappers branch February 14, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants