Feature/Add minimal k8s scheduler #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertjndw
requested changes
Jun 4, 2024
HadesScheduler/k8s/k8s.go
Outdated
Comment on lines
18
to
34
| type K8sConfig struct { | ||
| // K8sNamespace is the namespace in which the jobs should be scheduled (default: hades-executor) | ||
| // This may change in the future to allow for multiple namespaces | ||
| K8sNamespace string `env:"K8S_NAMESPACE,notEmpty" envDefault:"hades-executor"` | ||
|
|
||
| // K8sConfigMode is used to determine how the Kubernetes client should be configured ("kubeconfig" or "serviceaccount") | ||
| ConfigMode string `env:"K8S_CONFIG_MODE,notEmpty" envDefault:"kubeconfig"` | ||
| } | ||
|
|
||
| // K8sConfigKubeconfig is used as configuration if used with a kubeconfig file | ||
| type K8sConfigKubeconfig struct { | ||
| kubeconfig string `env:"KUBECONFIG"` | ||
| } | ||
|
|
||
| // K8sConfigServiceaccount is used as configuration if used with a service account | ||
| type K8sConfigServiceaccount struct { | ||
| } |
There was a problem hiding this comment.
Personally, I prefer to have nested structs in this case. I mean in theory we can check for all env variables and try to load them. Depending on the ConfigMode we then select one of the nested structs
HadesScheduler/k8s/k8s.go
Outdated
| job: job, | ||
| k8sClient: k.k8sClient, | ||
| namespace: k.namespace, | ||
| sharedVolumeName: "shared", |
There was a problem hiding this comment.
Does it have side-effects on parallel builds if we name all the shared volumes the same?
Mtze
force-pushed
the
feature/add-minimal-k8s-scheduler
branch
from
7700dad
to
ec53594
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Open Problems