Display primary nationality #10
Conversation
There was a problem hiding this comment.
The absolute value for the top margin is not elegant but without this the emoji moves vertically down since the font size has been increased for readability and overall improved look. There's definitely a nicer way to do it but I'm not sure how at the moment, I'm open to suggestions, thanks in advance.
There was a problem hiding this comment.
Removing the badge class seems like a "necessary evil" to get the text displayed to the right of the badges again (previously there was a bug that the text floated onto the next line below, which caused it to render behind content that was actually supposed to be on the next line). Removing the badge class oddly fixes this behavior, but the gray background associated with badges is of course gone.
Ayedrian
changed the title
…ntum/team-allocator into feature/display-primary-nationality
…ntum/team-allocator into feature/display-primary-nationality
|
What changed: A new attribute in the CSV (a person's primary nationality, specified using ISO 3166-1 alpha-3) is displayed using the corresponding flag (emoji) in the preview card and using the flag as well as country code in the detailed person view. Why the changes: A functional requirement was requested that instructors be able to see a person's primary nationality. Testing steps: Start up a container using the README instructions, distribute the people in the pool according to some constraints of your choice, confirm that the emoji flags are being displayed in the preview cards and that hovering over them shows the country code, click on a person's card to open the detailed view and confirm that both the flag as well as the country code are listed. |
The way the emojis are resized is not ideal with some rather ugly inline CSS "hacks", other than that displaying nationality in both the small card as well as the detailed view is implemented.