Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-reproducibility issue in packaging #1343

Closed
Apteryks opened this issue Jul 17, 2020 · 0 comments · Fixed by #1344
Closed

Non-reproducibility issue in packaging #1343

Apteryks opened this issue Jul 17, 2020 · 0 comments · Fixed by #1344

Comments

@Apteryks
Copy link

Building the package is not reproducible even with the SOURCE_DATE_EPOCH environment variable set.

The problem is setting the date explicitly: https://github.com/lsegal/yard/blob/main/yard.gemspec#L14.
This shouldn't be done (see: rubygems/rubygems#1232 (comment)).

Steps to reproduce

  1. Build the YARD gem today
  2. Wait for a day to pass.
  3. Build the YARD gem again.

Actual Output


diff -r /gnu/store/djj5g26545667gyaw8n2zx3c4grxjbsw-ruby-yard-with-tests-0.9.25/lib/ruby/vendor_ruby/specifications/yard-0.9.25.gemspec /gnu/store/djj5g26545667gyaw8n2zx3c4grxjbsw-ruby-yard-with-tests-0.9.25-check/lib/ruby/vendor_ruby/specifications/yard-0.9.25.gemspec
12c12
<   s.date = "2020-07-15"
---
>   s.date = "2020-07-17"

Expected Output


diff -r /gnu/store/djj5g26545667gyaw8n2zx3c4grxjbsw-ruby-yard-with-tests-0.9.25/lib/ruby/vendor_ruby/specifications/yard-0.9.25.gemspec /gnu/store/djj5g26545667gyaw8n2zx3c4grxjbsw-ruby-yard-with-tests-0.9.25-check/lib/ruby/vendor_ruby/specifications/yard-0.9.25.gemspec
12c12

(shouldn't be any difference)

Environment details:

GNU Guix
Ruby 2.6.5
YARD 0.9.25

I have read the Contributing Guide.

adam12 added a commit to adam12/yard that referenced this issue Jul 17, 2020
Rubygems will automatically set this for us.

Closes lsegal#1343
@adam12 adam12 mentioned this issue Jul 17, 2020
4 tasks
lsegal added a commit that referenced this issue Dec 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant