Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing Windows build #530

Merged
merged 8 commits into from
Feb 16, 2022
Merged

Fix failing Windows build #530

merged 8 commits into from
Feb 16, 2022

Conversation

marcelwa
Copy link
Contributor

Trying to compile with different toolsets under Windows reveals compilation errors. I will open a separate issue pointing to this PR.

@marcelwa
Copy link
Contributor Author

As mentioned in #531, this PR fixes a couple of compilation errors on Windows. If you want, you could merge this PR now. Do you want me to revert the changes I made to your Windows CI? They were only intended to showcase the problem.

@marcelwa marcelwa marked this pull request as ready for review February 16, 2022 15:00
@lee30sonia
Copy link
Member

Are these toolsets commonly-used ones? If so, I think we can keep them.

@marcelwa
Copy link
Contributor Author

I believe v142 is the default in Visual Studio 2019. I thought it would be beneficial to additionally test with Clang via the ClangCL toolset.

@lee30sonia
Copy link
Member

Looks good to me. Could you please resolve the conflict (keeping yours) so that I can merge it? Thanks!

@lee30sonia
Copy link
Member

@aletempiac FYI since your code is affected

@marcelwa marcelwa changed the title Failing Windows Build Fix failing Windows build Feb 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #530 (c9eeb4f) into master (f427196) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #530   +/-   ##
=======================================
  Coverage   82.61%   82.61%           
=======================================
  Files         146      146           
  Lines       18099    18099           
=======================================
  Hits        14953    14953           
  Misses       3146     3146           
Impacted Files Coverage Δ
include/mockturtle/utils/tech_library.hpp 84.58% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f427196...c9eeb4f. Read the comment docs.

@lee30sonia lee30sonia merged commit e147c52 into lsils:master Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants