-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix failing Windows build #530
Conversation
…ndows compilation behavior
…or that it was intended to showcase
As mentioned in #531, this PR fixes a couple of compilation errors on Windows. If you want, you could merge this PR now. Do you want me to revert the changes I made to your Windows CI? They were only intended to showcase the problem. |
Are these toolsets commonly-used ones? If so, I think we can keep them. |
I believe |
Looks good to me. Could you please resolve the conflict (keeping yours) so that I can merge it? Thanks! |
@aletempiac FYI since your code is affected |
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
=======================================
Coverage 82.61% 82.61%
=======================================
Files 146 146
Lines 18099 18099
=======================================
Hits 14953 14953
Misses 3146 3146
Continue to review full report at Codecov.
|
Trying to compile with different toolsets under Windows reveals compilation errors. I will open a separate issue pointing to this PR.