Improve man page #107
Merged
Improve man page #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masatake
reviewed
Oct 2, 2020
Lsof.8
Outdated
| # reload anything using old SSL | ||
| lsof -t /lib/*/libssl.so.* | xargs -r kill -HUP | ||
|
|
||
| # get list of processes and then iterate over them |
There was a problem hiding this comment.
It seems that one extra white space is at the start of the line. Could you remove it for aligning.
kurahaupo
force-pushed
the
patch-1
branch
2 times, most recently
from
3bb7496
to
9248da1
Compare
|
Do you allow me to rearrange the commits? I guess you are using GitHub's web UI. It may be hard to reflect my comments to your change with the UI. |
kurahaupo
force-pushed
the
patch-1
branch
3 times, most recently
from
e3fbaf6
to
c2cdd73
Compare
(The "kill" command doesn't read stdin, so anything _piped to_ it would be ignored.)
|
Done. (And properly attributed the commits to my normal public persona.) |
|
Thank you. |
|
Putting examples to the man page is a good idea. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "piped to" description is flat wrong, because "kill" doesn't read anything from stdin.
Saying that one command line option "selects" another is weird; "implies" would be clearer, both times it's mentioned.
Also added some examples.