-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for ghc-8.10.1 #305
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jneira
commented
May 13, 2020
•
edited
Loading
edited
- WIP, it does not compile:
- Issue Support ghc-8.10 #269
I've made it compile here in commit infinity0@0807fc9 and it seems to work fine. Not entirely sure about my fixes though:
Everything else should be pretty reasonable. |
lukel97
reviewed
Aug 5, 2020
This was referenced Aug 5, 2020
Only data-tree-print is needed now Co-authored-by: Luke Lau <luke_lau@icloud.com>
more GHC 8.10.1 fixes
@jneira Any chance I could get push access to this branch? I've rebased it and got it building on ghc-8.8 |
@bubba sure, feel free to open a new pr or alternatively you can do a pr against my branch |
Superseded by #312 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.