Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused TypeUtils #2

Merged
merged 2 commits into from
Aug 9, 2016
Merged

Remove unused TypeUtils #2

merged 2 commits into from
Aug 9, 2016

Conversation

Gurkenglas
Copy link
Contributor

No description provided.

@lspitzner
Copy link
Owner

does not compile.. is this meant as a work-in-progress?

Looks like I'll be repeating the following steps:
- cabal build this on my docker setup which finally got me in position
to somehow build this
- see a compiler error
- fix it on the host machine's git project
- commit + push to my fork
- pull in the docker thing
@Gurkenglas
Copy link
Contributor Author

I didn't think it wouldn't typecheck. I am now in position to typecheck pull requests before I submit them. That took a while. Here, this should work?

@lspitzner
Copy link
Owner

Btw you can amend your last commit in such cases (and force-push it) as to avoid creating a non-working commit in the project's public history. (or squash, which is the same for more than 2 commits.)

@lspitzner lspitzner merged commit 6748773 into lspitzner:master Aug 9, 2016
@lspitzner
Copy link
Owner

oh, i can squash and merge too.. neat.

@lspitzner
Copy link
Owner

Thanks!

@Gurkenglas Gurkenglas deleted the patch-1 branch August 9, 2016 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants