Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(llm): bing livecheck & feat: tts prompt #818

Merged
merged 21 commits into from
May 16, 2023
Merged

fix(llm): bing livecheck & feat: tts prompt #818

merged 21 commits into from
May 16, 2023

Conversation

WangEdward
Copy link
Contributor

No description provided.

@WangEdward WangEdward changed the title fix(llm): bing livecheck fix(llm): bing livecheck & feat: tts prompt May 15, 2023
lss233
lss233 requested changes May 15, 2023
View reviewed changes
framework/llm/microsoft/models.py Outdated Show resolved Hide resolved
framework/llm/microsoft/models.py Outdated Show resolved Hide resolved
prompts/default_speak.yml Outdated Show resolved Hide resolved
prompts/default.yml Show resolved Hide resolved
@WangEdward WangEdward requested a review from lss233 May 15, 2023 11:03
lss233
lss233 requested changes May 15, 2023
View reviewed changes
Copy link
Owner

@lss233 lss233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

辛苦了！还有一些问题需要看一下……

framework/llm/microsoft/models.py Show resolved Hide resolved
framework/universal.py Outdated Show resolved Hide resolved
prompts/default.yml Outdated Show resolved Hide resolved
prompts/default.yml Outdated Show resolved Hide resolved
prompts/default.yml Outdated Show resolved Hide resolved
framework/conversation.py Show resolved Hide resolved
framework/conversation.py Outdated Show resolved Hide resolved
framework/conversation.py Show resolved Hide resolved
@WangEdward
Copy link
Contributor Author

好的，我明天来改

WangEdward and others added 8 commits May 16, 2023 08:57
@WangEdward @lss233
fix: type check
0df83e1 
Co-authored-by: Dark Litss <8984680+lss233@users.noreply.github.com>
@WangEdward @lss233
Update prompts/default.yml
274aba9 
Co-authored-by: Dark Litss <8984680+lss233@users.noreply.github.com>
@WangEdward @lss233
refactor: framework/universal.py
4a28535 
Co-authored-by: Dark Litss <8984680+lss233@users.noreply.github.com>
@WangEdward
fix: missing trust_env
e4304fd
@WangEdward @lss233
refactor: supported_llms wildcard
72dc91d 
这是一个直接处理的通配符，强迫症表示很难受。。。。。。

Co-Authored-By: Dark Litss <8984680+lss233@users.noreply.github.com>
@WangEdward
fix(conversation): speak function
9242060
@WangEdward @lss233
refactor: remove unnecessary prompt action
1258762 
Co-Authored-By: Dark Litss <8984680+lss233@users.noreply.github.com>
@WangEdward
feat(llm): raise exception for bing livecheck
059778d
@WangEdward WangEdward requested a review from lss233 May 16, 2023 02:25
lss233
lss233 requested changes May 16, 2023
View reviewed changes
Copy link
Owner

@lss233 lss233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

默认预设可以删除非必要的处理流程

prompts/default.yml Show resolved Hide resolved
framework/conversation.py Show resolved Hide resolved
@WangEdward @lss233
refactor: change parameter type
dbf88c5 
Co-Authored-By: Dark Litss <8984680+lss233@users.noreply.github.com>
@lss233 lss233 merged commit dd5d7aa into lss233:refactor-v3 May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lss233 lss233 lss233 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WangEdward @lss233