DM-42809: Add more detailed logging of calib preload #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
_filter_datasets is called with a wide array of arguments, making it essential that any logging or error messages disambiguate which call they apply to. Centralizing the argument printing will minimize code duplication as more logging is added.
Under some conditions, finding the correct calibs in the central repo is slower than transferring the actual files or their validities. Instrumenting each query should make it easier to find the bottleneck.
kfindeisen
force-pushed
the
tickets/DM-42809
branch
from
4199dd7
to
e7ede2a
Compare
ebellm
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds extra timing blocks to the calib search path, to try to pin down anomalously slow (tens of seconds) calib queries.