-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(foreman role) add foreman discovery plugin #627
Conversation
06295f4
to
4114433
Compare
4114433
to
a0a2d0e
Compare
@@ -106,6 +106,9 @@ foreman_proxy::log_buffer: 2000 | |||
foreman_proxy::log_buffer_errors: 1000 | |||
foreman_proxy::log_level: "DEBUG" | |||
foreman_proxy::log: "/var/log/foreman-proxy/proxy.log" | |||
foreman_proxy::plugin::discovery::image_name: "fdi-image-4.99.99-6224850.tar" | |||
foreman_proxy::plugin::discovery::install_images: true | |||
foreman_proxy::plugin::discovery::source_url: "https://github.com/lsst-it/foreman-discovery-image/releases/download/lsst-4.99.99/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couldn't find this one, wanted to see the other half of the magic 🪄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The foreman_proxy::plugin::discovery
class is https://github.com/theforeman/puppet-foreman_proxy/blob/master/manifests/plugin/discovery.pp
The firewalld/nft tftp fix is theforeman/foreman-discovery-image#151
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fact which is being put in udev_fact.zip
I am proposing to add to the puppet/systemd
module. voxpupuli/puppet-systemd#292
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! i follow up those to get the entire picture, this was just great work (theforeman/foreman-discovery-image#151)
I'm going to change this PR back to draft status to look at BMC management. When discovery creates a host, it is add a BMC type interface to the host, which is sort of strange as BMC support is disabled. |
a0a2d0e
to
05b336e
Compare
72cbabf
to
35baa7f
Compare
The default limit of 100 is too low for the udev fact.
35baa7f
to
facfb77
Compare
I have enabled foreman's bmc support (and manually tested it as working with one of the new k8s nodes) and de-duplicated some of the tests. |
The default is to use the mac address of the PXE boot interface. Our normal workflow is the record the mac address of the ipmi interface during racking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
Related to lsst-it/foreman_templates#2