Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(foreman role) add foreman discovery plugin #627

Merged
merged 10 commits into from
Aug 16, 2022
Merged

Conversation

jhoblitt
Copy link
Member

@jhoblitt jhoblitt commented Aug 4, 2022

@jhoblitt jhoblitt marked this pull request as draft August 4, 2022 21:33
@jhoblitt jhoblitt force-pushed the IT-3840/foreman_discovery branch 7 times, most recently from 06295f4 to 4114433 Compare August 10, 2022 21:31
@jhoblitt jhoblitt changed the title (WIP) (foreman role) add foreman discovery plugin (foreman role) add foreman discovery plugin Aug 10, 2022
@jhoblitt jhoblitt requested a review from cbarria August 10, 2022 22:01
@jhoblitt jhoblitt marked this pull request as ready for review August 10, 2022 22:01
@@ -106,6 +106,9 @@ foreman_proxy::log_buffer: 2000
foreman_proxy::log_buffer_errors: 1000
foreman_proxy::log_level: "DEBUG"
foreman_proxy::log: "/var/log/foreman-proxy/proxy.log"
foreman_proxy::plugin::discovery::image_name: "fdi-image-4.99.99-6224850.tar"
foreman_proxy::plugin::discovery::install_images: true
foreman_proxy::plugin::discovery::source_url: "https://github.com/lsst-it/foreman-discovery-image/releases/download/lsst-4.99.99/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couldn't find this one, wanted to see the other half of the magic 🪄

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact which is being put in udev_fact.zip I am proposing to add to the puppet/systemd module. voxpupuli/puppet-systemd#292

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! i follow up those to get the entire picture, this was just great work (theforeman/foreman-discovery-image#151)

@jhoblitt
Copy link
Member Author

I'm going to change this PR back to draft status to look at BMC management. When discovery creates a host, it is add a BMC type interface to the host, which is sort of strange as BMC support is disabled.

@jhoblitt jhoblitt marked this pull request as draft August 11, 2022 18:15
@jhoblitt jhoblitt force-pushed the IT-3840/foreman_discovery branch 2 times, most recently from 72cbabf to 35baa7f Compare August 12, 2022 18:30
@jhoblitt jhoblitt marked this pull request as ready for review August 12, 2022 18:40
@jhoblitt jhoblitt requested a review from cbarria August 12, 2022 18:40
@jhoblitt
Copy link
Member Author

I have enabled foreman's bmc support (and manually tested it as working with one of the new k8s nodes) and de-duplicated some of the tests.

The default is to use the mac address of the PXE boot interface. Our
normal workflow is the record the mac address of the ipmi interface
during racking.
Copy link
Contributor

@cbarria cbarria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

@jhoblitt jhoblitt merged commit 7a70e13 into master Aug 16, 2022
@jhoblitt jhoblitt deleted the IT-3840/foreman_discovery branch August 16, 2022 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants