Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44444: Remove version cap on structlog #249

Merged
merged 1 commit into from
May 30, 2024
Merged

DM-44444: Remove version cap on structlog #249

merged 1 commit into from
May 30, 2024

Conversation

rra
Copy link
Member

@rra rra commented May 30, 2024

structlog uses CalVer and changes the major version for each year. The structlog developers recommend letting the version float, since the major version has no semantic significance. Backwards compatibility is handled through deprecation warnings.

@rra
Copy link
Member Author

rra commented May 30, 2024

Tests should pass once rebased on top of #248.

@rra rra requested a review from jonathansick May 30, 2024 15:12
Copy link
Member

@jonathansick jonathansick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good.

structlog uses CalVer and changes the major version for each year.
The structlog developers recommend letting the version float, since
the major version has no semantic significance. Backwards
compatibility is handled through deprecation warnings.
@rra rra enabled auto-merge May 30, 2024 18:05
@rra rra merged commit 9fc97b5 into main May 30, 2024
4 checks passed
@rra rra deleted the tickets/DM-44444a branch May 30, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants