DM-37079: Add sites to RubinTV app #130
Conversation
This commit also moves the models into a YAML file, installs dacine to convert the resulting dict to Camera objects and changes the root endpoint to yield a homepage that lists locations instead of the summit's cameras
Fixes missing location var not passed to allsky templates and deprecated download_as_string() replaced by download_as_bytes()
Also reorganise/rename js scripts with an eye to keeping things simple for more cameras to be brought online
Also fixes several js bugs that prevented tables from showing/updating
Remove unnecessary date-based update test Change date on allsky tests to match minimal Historical Data Make tests failing on minimal load use full app Fix the table control shifting width bug Remove empty metadata check from refresher function Rename and update incorrect docstring in historical data method Replace Bucket.get_blob() with less expensive Bucket.blob()
Also fix historical night reports parameter type bug
Redraw table completely on checkbox change to allow keeping of default heading order
Also attempt fixing misleading channel statuses on clicking 'back' in browser
ugyballoons
force-pushed
the
tickets/DM-37079
branch
from
187da66
to
f9e9eb5
Compare
ugyballoons
force-pushed
the
tickets/DM-37079
branch
from
f9e9eb5
to
fd6fd57
Compare
| @@ -0,0 +1,37 @@ | |||
| from pathlib import Path | |||
There was a problem hiding this comment.
This whole file is a pattern I am not used to seeing, which worries me. You have no defined functions or classed, so it's more like a script, and you're importing cameras and locations which are defined in here. I'm not saying it's necessarily bad, but it's not something I'm familiar with, and it does make me wonder if there are good reasons to avoid this pattern.
There was a problem hiding this comment.
Hmm... it did feel a little maverick as I was writing it. I'll look up what alternative patterns there are for loading yaml into dataclasses
There was a problem hiding this comment.
I mean, if these were in get_x() functions I wouldn't have blinked, it's just the script-like nature of the file and importing those variable felt a little unusual.
There was a problem hiding this comment.
We agreed OOB to fix this on the next ticket in favour of deploying the new version for tonight's run.
Add multiple locations to the app, each with it's own GCS Bucket.
Add functionality to display Night Report data (temporarily disabled).
Fix bogus heartbeat status displays.