-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tickets/DM-39447 #186
Tickets/DM-39447 #186
Conversation
2b63d68
to
9b8dc72
Compare
Hi! Since all checks have passed I see that the update works. But just for reference, if you could paste here the code that you used to make the updates, it would make it useful to keep track of what happened. Also, please make sure to update the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, made a few small comments in conversation and the empty file.
tests/testData/gen3TestRepo/update
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this file meant to be there?
Tags should be made on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens when you run butler query-datasets tests/testData/gen3TestRepo/
? When I do it the physical_filter
of all the data is still 'g' and not 'g_6' as I think it should be? Or is that not right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can leave the database as is for now since these tests are passing and fighting the butler isn't the point of these tests. Just want us to keep in mind this disparity between the butler database and the actual headers of our fits files in case it comes back to bite us later.
Perfect! Thanks to both, @jbkalmbach and @suberlak . Merging |
Fixing filter names in testData fits files from "g" to the new "g_6".
For all the testData/gen3TestRepo fits files, the filter value was updated to comply with new obs_lsst ts8 translator convention. The update was performed with the following snippet: