DM-34134: Reintegrate activator with upload.py #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfindeisen
force-pushed
the
tickets/DM-34134
branch
7 times, most recently
from
48b8f28 to
38b905f
Compare
kfindeisen
force-pushed
the
tickets/DM-34134
branch
from
38b905f to
9eb5818
Compare
ktlim
approved these changes
Mar 23, 2022
This change also fixes the unit tests to test the correct behavior instead of patching over it.
kfindeisen
force-pushed
the
tickets/DM-34134
branch
2 times, most recently
from
690ae0d to
77146b3
Compare
The script for generating the file is called from the activator rather than during container setup, because it needs to be in python/activator/ anyway.
kfindeisen
force-pushed
the
tickets/DM-34134
branch
from
77146b3 to
8ab663d
Compare
kfindeisen
referenced
this pull request
Mar 24, 2022
This is a workaround for RawIngestTask's lack of remote support; MiddlewareInterface's support for remote ingest has been preserved in case it can be made to work later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a number of bugs in
activator.pythat appear during script initialization and earlynext_visithandling. A prompt processing service based on this branch runs until it hits a bug inMiddlewareInterface.ingest_image, which is late enough that all interactions with the uploader script appear to be resolved.Any advice on a less hacky way to handle 38b905f would be greatly appreciated.