DM-41442: Add focal plane mosaic construction to cp_pipe/cp_verify #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erykoff
reviewed
May 22, 2024
| ) | ||
|
|
||
| outputExp = cT.Output( | ||
| name="calexpBin", |
There was a problem hiding this comment.
Should the default name be biasBin to go with bias?
|
|
||
| class VisualizeMosaicCalibConnections(pipeBase.PipelineTaskConnections, dimensions=("instrument",)): | ||
| inputExps = cT.Input( | ||
| name="calexpBin", |
There was a problem hiding this comment.
And I think this should be biasBin to match.
| ) | ||
|
|
||
| outputExp = cT.Output( | ||
| name="calexpBin", |
There was a problem hiding this comment.
In fact the default should probably be flat to signify that this is something over the flat (per filter) (all related connections).
erykoff
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add variety of subclasses of task/config to support different input dimensions.