Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tickets/opsim 1084 #373

Merged
merged 3 commits into from
Oct 18, 2023
Merged

Tickets/opsim 1084 #373

merged 3 commits into from
Oct 18, 2023

Conversation

yoachim
Copy link
Member

@yoachim yoachim commented Oct 16, 2023

Update pre-computed DDF grid so it is sure to cover desired times.

@rhiannonlynne
Copy link
Member

I think maybe the change to the "versions" got pushed directly to main that this PR is in support of?

@rhiannonlynne
Copy link
Member

I don't think we have this documented elsewhere ...

the "ddf grid" generated by this code (and in the data downloads) contains what? The pre-scheduled DDF visits, starting at ?
Or a grid of potential times, but not the actual times?
What is optimized when the scheduler reports "Optimizing DDF " on startup?
What happens if the survey start for a simulation is different than survey_start_mjd that is used to generate the DDFgrid?

Copy link
Member

@rhiannonlynne rhiannonlynne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind putting some thoughts about what the DDF grid is or does in documentation somewhere? Could start out by reply to this PR and then transfer to the doc pages, which might be the lowest effort needed for the moment.

@rhiannonlynne
Copy link
Member

For future reference ..
The DDF grid file is a lookup table of the skybrightness/airmass/m5 depth over time for each of the DDF fields.
The scheduler does the work of placing the DDF observations (as requested in the configuration) over time based on how many are requested, what m5 depth limits are in place, etc. -- although it does this for each DDF separately (so you can have collisions).

@yoachim yoachim merged commit 41fa5af into main Oct 18, 2023
7 of 9 checks passed
@rhiannonlynne rhiannonlynne deleted the tickets/OPSIM-1084 branch November 1, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants