Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last mysql type override from APDB #229

Merged
merged 2 commits into from
Jun 14, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

There was one remaining column with a MySQL type override in the APDB schema:

- name: lcPeriodic
  "@id": "#SSObject.lcPeriodic"
  datatype: binary
  length: 768
  description: Periodic light curve features computed on phase/distance-corrected magnitudes (H), 6x32 floats.
  mysql:datatype: BLOB(768)

I don't believe this is necessary, because APDB does not use MySQL.

Copy link
Contributor

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! There are also mysql:engine and mysql:charset keys in few places, I think you can drop them too.

@JeremyMcCormick
Copy link
Collaborator Author

Looks great! There are also mysql:engine and mysql:charset keys in few places, I think you can drop them too.

Okay, I will drop those as well. Thanks!

These should not be needed as this database is in Postgres.
@JeremyMcCormick JeremyMcCormick merged commit e44cf8f into main Jun 14, 2024
4 checks passed
@JeremyMcCormick JeremyMcCormick deleted the u/jeremym/apdb-remove-mysql-override branch June 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants