Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-44967: (hotfix) Change datatype for vignette fields. #234

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

ktlim
Copy link
Contributor

@ktlim ktlim commented Jun 25, 2024

No description provided.

@gpdf
Copy link
Collaborator

gpdf commented Jun 25, 2024

What does "hotfix" signify, specifically?

yml/cdb_latiss.yaml Outdated Show resolved Hide resolved
@ktlim
Copy link
Contributor Author

ktlim commented Jun 25, 2024

"hotfix" signifies that this is currently breaking deployments at the Summit and Base and that we're losing ConsDB insertions at the Summit from LATISS as a result.

@gpdf
Copy link
Collaborator

gpdf commented Jun 25, 2024

So in this case "hotfix" means you're going to deploy to summit without waiting for a standard release? But as far as processing this PR it doesn't mean anything procedurally unusual other than "do it quickly"?

@gpdf gpdf self-requested a review June 25, 2024 21:24
@ktlim
Copy link
Contributor Author

ktlim commented Jun 25, 2024

I'd like to merge this immediately.

While I can build an alembic migration off a branch, I'd rather do it off main.

I also don't want to bump the version number, as the previous one is totally unusable and never applied to any real data.

Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although this is a schema change, it's to what appears to be a non-working, incompatible with upstream data, current version, so this is approved for rapid deployment and doesn't require special version number treatment, etc.

@ktlim
Copy link
Contributor Author

ktlim commented Jun 25, 2024

Thanks!

@ktlim ktlim merged commit a9dd054 into main Jun 25, 2024
4 checks passed
@ktlim ktlim deleted the tickets/DM-44967-hotfix branch June 25, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants