Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily change MatchesTruth.truth_type to an int from short #241

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

JeremyMcCormick
Copy link
Collaborator

Fix portal bug with short not being handled correctly by Firefly plotting interface. It does not recognize short as a plottable data type.

Fix portal bug with short not being handled correctly by Firefly
plotting interface. It does not recognize short as a plottable data
type.
Copy link
Collaborator

@gpdf gpdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I have verified that other int columns are accepted for plotting.

@JeremyMcCormick JeremyMcCormick merged commit 4b89448 into main Jul 17, 2024
5 checks passed
@JeremyMcCormick JeremyMcCormick deleted the u/jeremym/revert-dp02-short branch July 17, 2024 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants