Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-43414: Change how Apdb is instanciated by ApdbMetricTask #123

Merged
merged 1 commit into from Apr 2, 2024

Conversation

andy-slac
Copy link
Contributor

Apdb API has changed the way how Apdb instances are created and how database is initialized. This patch updates code in ApdbMetricTask and unit tests for new Apdb API.

{Summary of changes. Prefix PR title with ticket handle.}


  • Passes Jenkins CI.
  • Documentation is up-to-date.

Preview the docs at: https://pipelines.lsst.io/v/DM-FIXME

Apdb API has changed the way how Apdb instances are created and
how database is initialized. This patch updates code in ApdbMetricTask
and unit tests for new Apdb API.
Copy link
Member

@kfindeisen kfindeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see the migration is straightforward. Just one question about the unit tests.

tests/test_configApdbLoader.py Show resolved Hide resolved
@andy-slac andy-slac merged commit b258240 into main Apr 2, 2024
2 checks passed
@andy-slac andy-slac deleted the tickets/DM-43414 branch April 2, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants