Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension of HclustParam with hclust function choice #17

Closed
BananaCancer opened this issue Jul 25, 2023 · 1 comment
Closed

Extension of HclustParam with hclust function choice #17

BananaCancer opened this issue Jul 25, 2023 · 1 comment

Comments

@BananaCancer
Copy link
Contributor

The HclustParam is currently using stats::hclust as clustering function. But other functions exist to do hierarchical clustering, for example fastcluster::hclust.
In some situations, the choice of the function used would be handy as the computation time can be quite high.

A solution would be to add a parameter to HclustParam to let the user choose the function. The default still being stats::hclust.

The new use would be: clusterRows(sce, HclustParam(clust.func = fastcluster::hclust))

Do you think such addition to bluster would be ok?

@LTLA
Copy link
Owner

LTLA commented Jul 26, 2023

Seems reasonable to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants