Allow reconfiguring VM defaults #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges to luau source code
|
Mind doing the same with LUA_API as well? |
|
I wonder if LUA_SIZECLASSES should be moved somewhere else, reconfiguring it is impossible. |
|
"Impossible" meaning "something breaks if you change it too much"? We can definitely remove it from luaconf. |
|
If you set it to less than 28, you will need to change size class distribution in lmem.cpp or you'll hit an assertion failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows to configure VM defaults from the build system (with defines
-Dor/D) without requiring changes to luau source code.I frequently override
LUA_USE_LONGJMPin cmake to build the test suite with and without exceptions, so this comes in handy.