Fix lua_*upvalue() when upvalue names aren't in debug info #787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add a unit test that only passes with the code change? |
|
Good call, added a test that compiles a script with no debug info, then yields in the middle of executing a closure to examine its upvalues. |
vegorov-rbx
approved these changes
Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lua_getupvalue()andlua_setupvalue()don't behave as expected when working with Lua closure whoseProtohas no debug info. The code currently usessizeupvaluesto do bounds checking of upvalue indices, but that's the size of the upvalue names array. It will always be0if theProtodoesn't have debug info.This uses
nupsinstead, and just returns""as the upvalue name if we don't have one, same as for C closures.