Include module name for definitions files #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JohnnyMorganz Please let us know if you're still interested in this PR (if so it would need to be rebased and the flag would need to default to false). Apologies that it was left unreviewed for so long. |
|
Yeah I'd still be interested in this. Will follow up on the weekend |
vegorov-rbx
approved these changes
Nov 20, 2023
vegorov-rbx
reviewed
Nov 20, 2023
| @@ -165,6 +166,8 @@ LoadDefinitionFileResult Frontend::loadDefinitionFile(GlobalTypes& globals, Scop | |||
| LUAU_TIMETRACE_SCOPE("loadDefinitionFile", "Frontend"); | |||
|
|
|||
| Luau::SourceModule sourceModule; | |||
| if (FFlag::LuauDefinitionFileSetModuleName) | |||
| sourceModule.name = packageName; | |||
There was a problem hiding this comment.
Please set humanReadableName as well.
|
Turns out whilst i was adding the test case that AstStatDeclareFunction |
vegorov-rbx
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #818
We set the
moduleNameof the source module to the providedpackageName.This then populates the relavent
definitionModuleName's on CTV/FTV/TTVs, so it allows us to lookup where they originated from.The one place I can see this having an impact inside of Luau code is the following:
https://github.com/Roblox/luau/blob/1fa8311a188a932233d2ce2bc6412e5bab37c035/Analysis/src/Error.cpp#L70-L90
Which will potentially change they way error messages are formatted.
Should there be a way to exclude definition files when calling
getDefinitionModuleName, so we can preserve this behaviour?