-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync to upstream/release/568 #865
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exposes a bug in CodeAllocator that needs to be fixed properly
alexmccord
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if not x then return end
should exclude falsy types after the block #356).Some examples:
Throwing calls like
error
orassert(false)
instead of 'return' are also recognized.Existing complex refinements like type/typeof and tagged union checks are expected to work, among others.
To enable this feature,
LuauTinyControlFlowAnalysis
exclusion has to be removed fromExperimentalFlags.h
.If will become enabled unconditionally in the near future.
Linter has been integrated into the typechecker analysis so that type-aware lint warnings can work in any mode
Frontend::lint
methods were deprecated,Frontend::check
has to be used instead withrunLintChecks
option set.Resulting lint warning are located inside
CheckResult
.Fixed large performance drop and increased memory consumption when array is filled at an offset (Fixes Filling array from offset can be slow #590)
Part of Type error suppression RFC was implemented making subtyping checks with
any
type transitive.In our work on the new type-solver:
--!nocheck
mode no longer reports type errors--!nonstrict
modules until all issues with strict mode typechecking are fixedIn native code generation:
LOP_NAMECALL
has been translated to IRtype
andtypeof
builtin fastcalls have been translated to IR/assembly