Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix website demo's string highlighting behaviour #942

Merged
merged 2 commits into from
Jun 6, 2023
Merged

Fix website demo's string highlighting behaviour #942

merged 2 commits into from
Jun 6, 2023

Conversation

BenMactavsin
Copy link
Contributor

@BenMactavsin BenMactavsin commented Jun 1, 2023

Fixes #935:

  • String literals that include \z escape sequence followed by newline characters are now correctly highlighted.
  • Unescaped backslash (\) character at the end of the line no longer acts like the \z escape sequence inside string literals when highlighting.

Fixes the highlighting behaviour of website demo when:
* String includes `\z` escape sequence followed by newline characters.
* String includes just a single backslash (`\`) character at the end of the line.
Second `ignoreWhitespace` assignment overrides the first assignment regardless.
@zeux zeux merged commit e788972 into luau-lang:master Jun 6, 2023
@zeux
Copy link
Collaborator

zeux commented Jun 6, 2023

Thanks!

@BenMactavsin BenMactavsin deleted the patch-1 branch June 7, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Website demo incorrectly highlight strings that have \z escape sequence(s) followed by newline character(s)
2 participants