-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE REQUEST] Permanent screens #208
Comments
I personally find it rather irritating that you, as a user have the possibility to have an empty/black screen and must serve the clock as content! It's a clock and should always show the clock (as it did in previous versions). I know the feature was added because you as a user have more possibilitys in features, Looked at the code and there is an defen already so clock_screens does'nt get remove. |
Well, the code is a mess, an array for the queue elements is a mess, the class design for the queue is a mess, the interface to the esphome service calls are messy .... I am using only 3.56% of the capabilities of EspHoMaTriXv2, the rest is Schnickschnack (German for "bells and whistles") to me. So i like the idea of a permanent screen, but only with a complete rethinking of the way to control the display (homeassistant service calls) and the internal structure. The last pull request from @andrewjswan shows the problem, he added a helpful feature, but how he had to pass the parameter in a "special" way. (a numeric parameter as part of a string) which is horror/abuse.... I will not spend my time on optimizing the code since it is working for me. But if you can provide PRs based on the "latest" branch feel free... I will support you |
I don't looked at the code so deeply but that doesn't sound good 😞 Sorry, don't have much time to optimize it either and it also works for my needs. |
a workaround is to use the on_empty_queue event to add the screen at the end of the lifetime |
Feature Request
With upcoming 2024.1.0 there is no direct way to set an screen (like clock and date) permanent (without a lifetime).
In my case the primary function of the device is a clock, and so it should always display a clock (like it did before).
Is your feature request related to a problem?
See discussion here: #93
Describe the solution / feature you'd like
An setting with permanent screen modes which ignores lifetime and keeps in the queue forever...
Or...
An new parameter to every function like "permanent=true". Is this set , the same happens as above.
Describe alternatives you've considered
Not solution but a workaround:
This should keep the clock alive.
The text was updated successfully, but these errors were encountered: