This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Update README.md + Fix display_on service not working #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typos - Add awtrix-light as another option for Ulanzi clock - Add/change services listed to fit 2023.3.5
- More typos - Added show_all_icons as breaking change.
Change default services from sample YAML to clearly identified in README
Added gauge_color service to description of text color services
Fix display on provided service not working
pplucky
changed the title
|
Hi, very nice. The documentation is very important but I didn't spend much time with it. I will review this pull request asap. thanx |
Yes, definitely. There are some things which were not crystal clear to me, namely the services part. It’s still not perfect, but I think it is much better. When I have more ideas to improve it, I will try to improve it more. |
lubeda
approved these changes
Mar 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
README.md enhancements
Fix display on provided service not working