Parse GitHub from website links #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! I believe this logic could be adapted and generalized for other types (i.e. twitter, gitlab, etc). So thanks a lot! |
|
@jvfe feel free to push to either this branch or we can finish up here and you can continue in your own - whatever's more comfortable |
jvfe
requested changes
Oct 12, 2022
For sure! I'll take a look as soon as I'm able. |
jvfe
approved these changes
Oct 12, 2022
jvfe
approved these changes
Oct 12, 2022
jvfe
added a commit
that referenced
this pull request
Oct 12, 2022
- Resolves conflict generated by #40 * master: test: Expand tests for getting external IDs Update helper.py Generalize URL compression Update helper.py Update helper.py Update helper.py Parse GitHub from website links
lubianat
reviewed
Oct 12, 2022
|
@lubianat can you change the project settings to enforce squash/merge and also auto-delete branches after merge? |
|
I can try, not sure how to do it though
Tiago
…On Wed, Oct 12, 2022 at 8:40 AM Charles Tapley Hoyt < ***@***.***> wrote:
@lubianat <https://github.com/lubianat> can you change the project
settings to enforce squash/merge and also auto-delete branches after merge?
—
Reply to this email directly, view it on GitHub
<#40 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4NC7374VCVZO55SW6STODWC2PQ7ANCNFSM6AAAAAARCYG7G4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Go to https://github.com/lubianat/pyorcidator/settings, scroll about 2/3 the way down, then you will see the following settings (below is the Bioregistry repo)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #37
Anyone want to flesh this out with additional logic for other types? e.g. twitter?