Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV #117

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Bump MSRV #117

merged 2 commits into from
Oct 13, 2022

Conversation

swsnr
Copy link
Collaborator

@swsnr swsnr commented Oct 13, 2022

Use 1.56 as MSRV, because once_cell uses edition 2021.

Set rust version in Cargo.toml and use edition 2021.

This adds support for edition 2021 which once-cell now requires.
@swsnr swsnr requested a review from lucab October 13, 2022 16:08
@swsnr
Copy link
Collaborator Author

swsnr commented Oct 13, 2022

@lucab While I'm at it, I'd also like to replace actions-rs/toolchain (which is no longer maintained) with https://github.com/dtolnay/rust-toolchain and remove all other actions-rs things we have.

Do you agree, and if so, can I do this in this merge request?

@lucab
Copy link
Owner

lucab commented Oct 13, 2022

Thanks for the heads up, I didn't notice that action-rs went unmaintained.
If the new thing can provide the same coverage, let's switch to that.
But better make that it's own PR. This one looks good to me as is.

@swsnr swsnr merged commit db4d476 into master Oct 13, 2022
@lucab
Copy link
Owner

lucab commented Oct 13, 2022

(We'll have to make semver bump after this)

@swsnr swsnr deleted the bump-msrv branch October 13, 2022 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants