-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logging: add support for writing to journald #34
Conversation
Got the memfd message working. It needed to have been sealed before being passed to journald. |
@jabedude nice! I did a first review pass and run the tests, I got the correct output in the journal. I think sealing is not strictly required but it plays better with the receiving logic in systemd-journald, so I'm ok with doing that. |
46e172b
to
16e5ca2
Compare
@lucab thanks! I integrated your comments and made some small tweaks. I think the PR is ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left a few minor comments, but I plan to have a deeper pass tomorrow. Can you please squash into a single commit in the meanwhile?
d0e2476
to
d21e607
Compare
Sure thing |
@jabedude thanks for all your work on this! This PR looks fine to me now. Is there anything else you planned to add here, or can I go ahead and merge? |
My pleasure! No, I think this is good to merge as is. I think we might want to add methods for consumers to log with arbitrary fields and data later though, but I need to look closer at |
@lucab could you please review my initial pass at adding journald logging support.
I only have the core logic of forwarding messages to journald in place
I am not able to pass journald a memfd and create a log entry. I've done a bit of research and only found some issues in
nix
with passing multiple fds, but that shouldn't matter in our case.Close: #32