Skip to content

Commit

Permalink
Fix longevity test runs (nginxinc#2065) (#3)
Browse files Browse the repository at this point in the history
* Fix longevity test runs (nginxinc#2065)

Problem:
Running longevity test mistakenly runs all other NFRs
make start-longevity-test and make stop-longevity-test mistakenly
executes all NFRs. Only longevity test must run.

Solution:
Problem was introduced in 18671fb
Ensure the env variables are exported so that they are passed to nfr-test target.

Testing:
- Ran make start-longevity-test and make stop-longevity-test successfully.

CLOSES - nginxinc#2064

* test notes

---------

Co-authored-by: Michael Pleshakov <pleshakov@users.noreply.github.com>
  • Loading branch information
lucacome and pleshakov authored May 31, 2024
1 parent 12834cf commit a8bc6a9
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/release-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ permissions:
jobs:
release:
runs-on: ubuntu-22.04
permissions:
contents: write
steps:
- name: Branch
id: branch
Expand Down
4 changes: 2 additions & 2 deletions tests/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@ nfr-test: ## Run the NFR tests on a GCP VM
NFR=true bash scripts/run-tests-gcp-vm.sh

.PHONY: start-longevity-test
start-longevity-test: START_LONGEVITY=true
start-longevity-test: export START_LONGEVITY=true
start-longevity-test: nfr-test ## Start the longevity test to run for 4 days in GKE

.PHONY: stop-longevity-test
stop-longevity-test: STOP_LONGEVITY=true
stop-longevity-test: export STOP_LONGEVITY=true
stop-longevity-test: nfr-test ## Stop the longevity test and collects results

.PHONY: .vm-nfr-test
Expand Down

0 comments on commit a8bc6a9

Please sign in to comment.